bundle bob in esm instead cjs #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e471646 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimaMachina
commented
Dec 22, 2022
Comment on lines
-11
to
+12
| const root: Argv = yargs.scriptName('bob').detectLocale(false).version(); | ||
| const root: Argv = yargs(hideBin(process.argv)).scriptName('bob').detectLocale(false).version(); |
There was a problem hiding this comment.
dimaMachina
requested review from
enisdenjo and
n1ru4l
and removed request for
n1ru4l
enisdenjo
reviewed
Jan 9, 2023
@enisdenjo default of what? now bob is bundled to ESM only, I test this alpha on graphql-eslint and graphql-config and everything works |
|
Node's runtime default if the extension is |
enisdenjo
approved these changes
Jan 9, 2023
Comment on lines
+42
to
+43
| - name: Lint ESLint | ||
| run: yarn lint |
There was a problem hiding this comment.
Don't worry I plan to switch to pnpm :)))
n1ru4l
reviewed
Jan 9, 2023
.changeset/nervous-carpets-shop.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| 'bob-the-bundler': minor | |||
There was a problem hiding this comment.
Isnt this a major release as it will break non esm supporting versions?
dimaMachina
commented
Jan 9, 2023
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compilerOptions.moduleto2020.jsextensionsLint ESLintci actiomn