Better WebAuthn and other error responses #2608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaleman
force-pushed
the
passkey-error-logging
branch
from
b9ed69d
to
031acc0
Compare
Firstyear
reviewed
Mar 4, 2024
| /// debug format with spaces | ||
| /// | ||
| /// Probably shouldn't use this with any of the complex types because it'll get weird quick! | ||
| pub fn variant_as_nice_string(&self) -> String { |
There was a problem hiding this comment.
yeah, aded it over here as a first run to get a nice response to the user
There was a problem hiding this comment.
Wouldn't it be better to just have a to_str that matches rather than a regex? Seems a bit overkill ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that thing where if you don't have UV you should get a slightly nicer error.
Checklist