Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream kaniko plugin #4

Merged
merged 1 commit into from Aug 30, 2021
Merged

Use upstream kaniko plugin #4

merged 1 commit into from Aug 30, 2021

Conversation

colinhoglund
Copy link
Member

We can use the upstream kaniko plugin now that drone/drone-kaniko#24 is merged.

Copy link
Member

@dskatz dskatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will public.ecr.aws/kanopy-sandbox will get proper name?

@colinhoglund
Copy link
Member Author

LGTM

Will public.ecr.aws/kanopy-sandbox will get proper name?

This is temporary, eventually we will have a non-sandbox registry to push to.

@colinhoglund colinhoglund merged commit 788b28e into main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants