feat: add process.env.ProgramW6432 as root location for binaries #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows systems, depending on the installed software (32 bit or 64 bit), querying process.env.PROGRAMFILES might yield 'C:\Program Files (x86)' even on a 64 bit system. That is why process.env.ProgramW6432 needs to be added as a root location, which holds 'C:\Program Files'.
|
Hi @jginsburgn, could you please help me to advance this pull request? Does it need to be approved by someone? |
pmvald
approved these changes
Apr 20, 2023
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows systems, depending on the installed software (32 bit or 64 bit), querying process.env.PROGRAMFILES might yield 'C:\Program Files (x86)' even on a 64 bit system. That is why process.env.ProgramW6432 needs to be added as a root location, which holds 'C:\Program Files'.