Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow headless to use GPU #266

Closed
wants to merge 5 commits into from
Closed

Conversation

elalish
Copy link

@elalish elalish commented Mar 28, 2023

Fixes #263

It seems reasonable to allow headless chrome to use the GPU if available, and on M1 macbooks it's the only thing that works now for WebGL since Chrome 109. I've verified this allows my karma tests to run again on my M1 macbook as long as I also specify the --use-angle=metal flag.

@barrtender
Copy link

I believe this test will fail with this change: https://github.com/karma-runner/karma-chrome-launcher/blob/master/test/jsflags.spec.js#L85

The flag seems to have been added from the original headless PR (6 years ago) and there's no specific note of it being load bearing so I don't see any reason for needing it.

@elalish
Copy link
Author

elalish commented Mar 29, 2023

Thanks, updated.

@elalish
Copy link
Author

elalish commented Mar 30, 2023

So, @barrtender do these test failures mean anything to you? I'm hoping this isn't related to my change...

@barrtender
Copy link

Did some investigation yesterday - I think it's just that the commit messages are in the wrong format. Can you rebase/squash the commits to get it in the standard format?

I suggest:
fix(Mac WebGL): Allow headless to use GPU

I think that would work.

@dollysingh3192
Copy link

Hey Guys,

Can we please merge it asap?

@pmvald
Copy link
Member

pmvald commented Apr 20, 2023

@elalish We just need to re-format the commit messages to pass the commitlint test, then we'll merge it. I suggest we squash all these three commits into one with a message like "feat: allow headless to use GPU" For more info on formatting see this - you can also check previous commits.

@elalish
Copy link
Author

elalish commented Apr 21, 2023

Closing in favor of #266.

@elalish elalish closed this Apr 21, 2023
@elalish elalish deleted the mac-headless branch April 21, 2023 16:45
@elalish
Copy link
Author

elalish commented Apr 21, 2023

Also, there's a cool feature called "Squash and Merge" on Github to avoid this problem, though I suppose there's no getting around the picky commitlint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome headless lost WebGL support on MacOS
4 participants