refactor: use onExit instaed of explicit emitter

karma-runner · Nov 29, 2013 · 3de66aa · 3de66aa
1 parent b36c24d
commit 3de66aa
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/lib/reporter.js b/lib/reporter.js
@@ -37,7 +37,7 @@ Store.mix(BasePathStore, {
 
 
 // TODO(vojta): inject only what required (config.basePath, config.coverageReporter)
-var CoverageReporter = function(rootConfig, emitter, helper, logger) {
+var CoverageReporter = function(rootConfig, helper, logger) {
   var log = logger.create('coverage');
   var config = rootConfig.coverageReporter;
   var basePath = rootConfig.basePath;
@@ -127,17 +127,16 @@ var CoverageReporter = function(rootConfig, emitter, helper, logger) {
     });
   };
 
-  // TODO(vojta): refactor to onExit
-  emitter.on('exit', function(done) {
+  this.onExit = function(done) {
     if (pendingFileWritings) {
       fileWritingFinished = done;
     } else {
       done();
     }
-  });
+  };
 };
 
-CoverageReporter.$inject = ['config', 'emitter', 'helper', 'logger'];
+CoverageReporter.$inject = ['config', 'helper', 'logger'];
 
 // PUBLISH
 module.exports = CoverageReporter;