Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded to lodash 4.5.0 #212

Closed
wants to merge 3 commits into from
Closed

Upgraded to lodash 4.5.0 #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a15e4ae
Upgraded to lodash 4.5.0
Feb 20, 2016
c523e61
fix(preprocessor): Use _.includes instead of _.contains
Feb 20, 2016
553ccf4
Merge branch 'master' of https://github.com/dwatling/karma-coverage
Feb 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/preprocessor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function createCoveragePreprocessor (logger, helper, basePath, reporters, covera
}, {})

// if coverage reporter is not used, do not preprocess the files
if (!_.contains(reporters, 'coverage')) {
if (!_.includes(reporters, 'coverage')) {
return function (content, _, done) {
done(content)
}
Expand All @@ -62,7 +62,7 @@ function createCoveragePreprocessor (logger, helper, basePath, reporters, covera
// check instrumenter override requests
function checkInstrumenters () {
return _.reduce(instrumenterOverrides, function (acc, literal, pattern) {
if (!_.contains(_.keys(instrumenters), String(literal))) {
if (!_.includes(_.keys(instrumenters), String(literal))) {
log.error('Unknown instrumenter: %s', literal)
return false
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"karma-firefox-launcher": "^0.1.6",
"karma-mocha": "^0.2.0",
"load-grunt-tasks": "^3.2.0",
"lodash": "^3.9.3",
"lodash": "^4.5.0",
"mocha": "^2.2.5",
"mocks": "0.0.15",
"sinon": "^1.14.1",
Expand Down