Update major libs dep fix #398 #403
Conversation
anthony-redFox
force-pushed
the
es6
branch
5 times, most recently
from
4f56205
to
f799fe4
Compare
|
@coreyfarrell and @johnjbarton please take a look |
| var context = istanbulLibReport.createContext(options) | ||
| var report = reports.create(reporterConfig.type || 'html', options) | ||
| const context = istanbulLibReport.createContext(options) | ||
| const report = reports.create(reporterConfig.type || 'html', options) |
There was a problem hiding this comment.
Sorry I can't figure out what this commit is achieving. I think it is:
fix(reporter): update calls to match new API in istanbul-lib-report v?
There was a problem hiding this comment.
I split refactoring and upgrade on separate PRs
There was a problem hiding this comment.
The class in lib/in-memory-report.js needs to extend the istanbul ReportBase class.
const { ReportBase } = require('istanbul-lib-report');
class InMemoryReport extends ReportBase {
constructor(opt) {
super(opt);
this.opt = opt;
}
// ... rest of the class..
}I think this is not picked up by your testing because the in-memory-report tests directly run the functions of a report instance instead of having istanbuljs execute the report. istanbuljs would fail to execute the in memory report as it lacks the execute function which is implemented by ReportBase.
Other than this nothing stands out.
|
I will do. Thanks |
anthony-redFox
force-pushed
the
es6
branch
2 times, most recently
from
0aa0714
to
199a89b
Compare
karma-runner#398 BREAKING CHANGES: major dependencies are updated
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| @@ -218,11 +218,11 @@ var CoverageReporter = function (rootConfig, helper, logger, emitter) { | |||
| coverageMap.merge(result.coverage) | |||
| } | |||
|
|
|||
| this.onRunComplete = function (browsers, results) { | |||
| this.onRunComplete = async function (browsers, results) { | |||
There was a problem hiding this comment.
Having this function async causes result.exitCode to be set too late to be taken into account when karma exits the process.
So when the coverage check thresholds are not met, the process still exits with code 0.
No description provided.