feat(web-server): run karma using multiple emulation modes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not bump the version number in |
|
Hi @vojtajina, do you need more information about this change before you can merge it? We rely on this fix and I'd like to see it merged soon. Thanks. |
|
Awesome. You don't have to bump the package.json, that happens automatically during the release... Can you please change the commit msg to Otherwise this LGTM, merge it in! |
sylvain-hamel
added a commit
that referenced
this pull request
Apr 1, 2014
feat: allow multiple IE versions in emulation modes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes karma-runner/karma#936, karma-runner/karma#631
This is related to another pull request that I'm going to send to https://github.com/karma-runner/karma right after this one.