refactor(adapter): fix static code analysis warnings

karma-runner · Mar 28, 2018 · a0b3ec8 · a0b3ec8
1 parent 8d2a914
commit a0b3ec8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/src/adapter.js b/src/adapter.js
@@ -161,7 +161,7 @@ function KarmaReporter (tc, jasmineEnv) {
   // Save link on native Date object
   // because user can mock it
   var _Date = Date
-  var startTimeCurrentSpec = new _Date().getTime();
+  var startTimeCurrentSpec = new _Date().getTime()
 
   /**
    * @param suite
@@ -234,7 +234,7 @@ function KarmaReporter (tc, jasmineEnv) {
     currentSuite = currentSuite.parent
   }
 
-  this.specStarted = function (specResult) {
+  this.specStarted = function () {
     startTimeCurrentSpec = new _Date().getTime()
   }
 

diff --git a/test/adapter.spec.js b/test/adapter.spec.js
@@ -253,14 +253,6 @@ describe('jasmine adapter', function () {
     it('should report time for every spec', function () {
       var counter = 3
 
-      function copySpecResult() {
-        var copy = {}
-        for(var i in spec.result) {
-          copy[i] = spec.result[i]
-        }
-        return copy
-      }
-
       spyOn(Date.prototype, 'getTime').and.callFake(function () {
         counter += 1
         return counter
@@ -270,8 +262,8 @@ describe('jasmine adapter', function () {
         expect(result.time).toBe(1) // 4 - 3
       })
 
-      reporter.specStarted(copySpecResult())
-      reporter.specDone(copySpecResult())
+      reporter.specStarted(Object.assign({}, spec.result))
+      reporter.specDone(Object.assign({}, spec.result))
 
       expect(karma.result).toHaveBeenCalled()
     })