feat: Propagate errors thrown in afterAll blocks #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksimr
reviewed
Mar 29, 2017
src/adapter.js
Outdated
| @@ -191,6 +191,18 @@ function KarmaReporter (tc, jasmineEnv) { | |||
|
|
|||
| this.jasmineDone = function (result) { | |||
| result = result || {} | |||
|
|
|||
| // Any errors in top-level afterAll blocks are given here. | |||
| if (result.failedExpectations && result.failedExpectations.length) { | |||
There was a problem hiding this comment.
Thanks
Only one note - extract the code to a function and remove duplication between jasmineDone and suiteDone
If an error is thrown in an afterAll block, it needs to be handled specially since the error isn't attached to a specific spec. This change won't fail any specific test, but will cause a general failure which will still cause overall run failure. Closes karma-runner#161
TheModMaker
force-pushed
the
feat-afterAllErrors
branch
from
e5fc540
to
f3fa264
Compare
|
@maksimr @dignifiedquire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error is thrown in an afterAll block, it needs to be handled
specially since the error isn't attached to a specific spec. This
change won't fail any specific test, but will cause a general failure
which will still cause overall run failure.
Closes #161