Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind jasmineEnv to configuration setters #223

Closed
wants to merge 1 commit into from
Closed

Bind jasmineEnv to configuration setters #223

wants to merge 1 commit into from

Conversation

nasvillanueva
Copy link

@nasvillanueva nasvillanueva commented Oct 29, 2018

Since jasmine@3.3.0, all jasmine single method configurations calls to this.deprecated primarily to print a deprecation warning. Those single method configuration should be called with an appropriate this, which would be the jasmineEnv.

Resolves #221

Since jasmine@3.3.0, all jasmine single method configurations calls to `this.deprecated` primarily to print a deprecation warning. Those single method configuration should be called with an appropriate `this`, which would be the jasmineEnv
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@nasvillanueva
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@Lalem001
Copy link
Contributor

Would this method avoid the deprecation notices?

@nasvillanueva
Copy link
Author

@Lalem001 No. This would allow calls to this.deprecated to proceed. Because of an incorrect this, it would terminate since that particular this doesn't have a deprecated method.

@nasvillanueva
Copy link
Author

@Lalem001 I just saw your PR. Closing this in favor of #224

@Lalem001 Lalem001 mentioned this pull request Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants