Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enforce LF and update .editorconfig #317

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

build: enforce LF and update .editorconfig #317

wants to merge 2 commits into from

Conversation

XhmikosR
Copy link
Collaborator

No description provided.

devoto13
devoto13 previously approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jginsburgn jginsburgn force-pushed the xhm/lf branch 2 times, most recently from aca1477 to 02e9479 Compare April 25, 2022 03:17
@jginsburgn
Copy link
Member

@XhmikosR

I think we should also enforce this when linting! See #320 and if you agree merge it.

@XhmikosR
Copy link
Collaborator Author

@jginsburgn you can land #320 after this lands if you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jginsburgn jginsburgn jginsburgn left review comments

@devoto13 devoto13 devoto13 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XhmikosR @jginsburgn @devoto13