Skip to content

Commit

Permalink
fix: use appium:platformVersion in browserName (if present)
Browse files Browse the repository at this point in the history
Use the value of `appium:platformVersion` (if present) in `browserName`.

Since the [capabilities config when using Appium][1] does not include a
browser version, but only the platform version, including the value of
`appium:platformVersion` in `browserName` is essential in order to be
able to identify which platform the logs refer to.

[1]: https://docs.saucelabs.com/mobile-apps/automated-testing/appium/virtual-devices/#ios-code-examples
  • Loading branch information
gkalpak committed Oct 24, 2022
1 parent 24795cb commit 34d82d0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/process-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ export function processConfig(config: any = {}, args: any = {}) {
}

// Browser name that will be printed out by Karma.
const browserName = `${args.browserName} ${args.browserVersion || args.version || ''} ${args.platformName || args.platform || ''}`;
const browserName =
`${args.browserName} ${args.browserVersion || args.version || ''} ` +
`${args.platformName || args.platform || ''} ${args['appium:platformVersion'] || ''}`.trim();

// In case "startConnect" is enabled, and no tunnel identifier has been specified, we just
// generate one randomly. This makes it possible for developers to use "startConnect" with
Expand Down

0 comments on commit 34d82d0

Please sign in to comment.