Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix automatic capabilities conversion from JWP to W3C #277

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: fix automatic capabilities conversion from JWP to W3C #277

wants to merge 3 commits into from

Commits on Oct 24, 2022

  1. fix: correctly convert JWP capabilities to W3C 

    The `processConfig()` function attempts to convert capabilities from the
deprecated JWP format to the new standard W3C one.

Fix the logic for detecting when capabilites are in JWP format.
(Previously, the logic was inverted.)

Also, make sure that the `sauce:options` property is correctly populated
in both cases.
    @gkalpak
    gkalpak committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    7ac14fb View commit details
    Browse the repository at this point in the history

  2. fix: do not convert IE9 from JWP to W3C 

    Update the automatic conversion of capabilities from JWP to W3C format
to exclude Internet Explorer 9. Although according to the
[SauceLabs docs][1] all versions of Internet Explorer support the new
W3C capabilities format, in reality only versions >=10 do.

SauceLabs support has confirmed this and said that until the docs are
fixed, _"the [Platform Configurator][2] would be the most reliable
reference for compliant capabilities"_. Indeed, in the Platform
Configurator, IE 9 only offers the option to select `JWP (legacy)` as
the capabilities format.

[1]: https://docs.saucelabs.com/dev/w3c-webdriver-capabilities/index.html#browser-compatibility
[2]: https://saucelabs.com/platform/platform-configurator
    @gkalpak
    gkalpak committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    51f5c41 View commit details
    Browse the repository at this point in the history

  3. fix: use appium:platformVersion in browserName (if present) 

    Use the value of `appium:platformVersion` (if present) in `browserName`.

Since the [capabilities config when using Appium][1] does not include a
browser version, but only the platform version, including the value of
`appium:platformVersion` in `browserName` is essential in order to be
able to identify which platform the logs refer to.

[1]: https://docs.saucelabs.com/mobile-apps/automated-testing/appium/virtual-devices/#ios-code-examples
    @gkalpak
    gkalpak committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    a00e886 View commit details
    Browse the repository at this point in the history