fix(client): prevent socket.io from hanging due to mocked clocks (#3695)

karma-runner · Oct 19, 2021 · 105da90 · 105da90
1 parent ab9ebf8
commit 105da90
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 57 deletions.
diff --git a/client/main.js b/client/main.js
@@ -16,7 +16,8 @@ var socket = io(location.host, {
   reconnectionDelayMax: Infinity,
   timeout: BROWSER_SOCKET_TIMEOUT,
   path: KARMA_PROXY_PATH + KARMA_URL_ROOT.substr(1) + 'socket.io',
-  'sync disconnect on unload': true
+  'sync disconnect on unload': true,
+  useNativeTimers: true
 })
 
 // instantiate the updater of the view

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -284,6 +284,7 @@
     "Merott Movahedi <merott@merott.com>",
     "Merrick Christensen <merrick.christensen@gmail.com>",
     "Michael Krotscheck <krotscheck@gmail.com>",
+    "Michael Vartan <michaelvartan@google.com>",
     "Michał Siwek <mike21@aol.pl>",
     "Milan Aleksic <milanaleksic@gmail.com>",
     "Milana Stojadinov <mstojadinov@renderedtext.com>",
@@ -435,7 +436,7 @@
     "qjobs": "^1.2.0",
     "range-parser": "^1.2.1",
     "rimraf": "^3.0.2",
-    "socket.io": "^3.1.0",
+    "socket.io": "^4.2.0",
     "source-map": "^0.6.1",
     "tmp": "^0.2.1",
     "ua-parser-js": "^0.7.28",

diff --git a/static/karma.js b/static/karma.js
@@ -338,7 +338,8 @@ var socket = io(location.host, {
   reconnectionDelayMax: Infinity,
   timeout: BROWSER_SOCKET_TIMEOUT,
   path: KARMA_PROXY_PATH + KARMA_URL_ROOT.substr(1) + 'socket.io',
-  'sync disconnect on unload': true
+  'sync disconnect on unload': true,
+  useNativeTimers: true
 })
 
 // instantiate the updater of the view