fix(logging): Summarize SKIPPED tests in debug.html. #1115
Conversation
| @@ -22,10 +22,17 @@ | |||
| info: function(info) { | |||
| if (info.dump && window.console) window.console.log(info.dump); | |||
| }, | |||
| complete: function() {}, | |||
| complete: function() { | |||
| console.log('Skipped ' + this.skipped + ' tests'); | |||
There was a problem hiding this comment.
Could you use window.console.log as in the other places?
|
Otherwise LGTM |
| var msg = result.skipped ? 'SKIPPED ' : (result.success ? 'SUCCESS ' : 'FAILED '); | ||
| if (result.skipped) { | ||
| this.skipped++; | ||
| return; |
There was a problem hiding this comment.
Why you remove print skipped test? ('SKIPPED testSuite description' line 36)
There was a problem hiding this comment.
Such tests talk about problems in code(test code, source code).
Usually you have to either fix the skipped test or delete.
And such annoying mechanism makes you pay attention to such tests.
There was a problem hiding this comment.
Indeed, these annoying messages force you to pay attention to tests that you have deliberately marked as not important. The deliberate act of marking tests to be SKIPPED is a signal that Karma should obey. The common case of marking tests to be skipped is the use of ddescribe() or iit() to isolate a single suite or test for debugging or analysis. But such debugging or analysis is more difficult than necessary when the console is filled with hundreds of lines of SKIPPED tests.
Occasionally a developer uses xit() to skip a single test while investigating some other problem. The summary line at the end of the Karma run reminds the developer to return to this case.
Before: hundreds of SKIPPING lines in console.log. After: A single summary line with a count. Closes karma-runner#1111
|
I like this change. LGTM |
|
I think this is good as well. When you do iit() you get tons of "SKIPPED" logs in the console which makes it hard to see anything else... |
Before: hundreds of SKIPPING lines in console.log.
After: A single summary line with a count.
Closes #1111