Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): Default remaining client options if any are set #1357

Merged
merged 1 commit into from
May 26, 2015
Merged

fix(config): Default remaining client options if any are set #1357

merged 1 commit into from
May 26, 2015

Conversation

firesock
Copy link
Contributor

Closes #961

@nemoDreamer
Copy link

🐼

@firesock
Copy link
Contributor Author

@maksimr Mainly wanted to keep the defaults in the same place in the file and access in a similar way to other defaults. Is it preferable to just use a simple top-level variable?

@dignifiedquire
Copy link
Member

lgtm

@maksimr
Copy link
Contributor

maksimr commented May 15, 2015

@firesock all properties of instance Config user can change in karma.config.js, I dont think make defaultConfig as public property of config good idea.

Thanks!

@dignifiedquire
Copy link
Member

#merge

@karmarunnerbot
Copy link
Member

Sent to presubmit as presubmit-master-pr-1357 Presubmit branch - Travis status

@karmarunnerbot karmarunnerbot merged commit 632dd5e into karma-runner:master May 26, 2015
@firesock
Copy link
Contributor Author

Sorry, was away for a while, couldn't pick up the comment. It was merged anyway, so I assume that's fine. Let me know if you still want the changes?

@snyk-bot snyk-bot mentioned this pull request May 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client.captureConsole isn't defaulted correctly if client config is defined
5 participants
@firesock @nemoDreamer @dignifiedquire @maksimr @karmarunnerbot