fix(client): dynamic protocol for socket.io

[ghost]

Look up location.protocol for socket.io,
in order to use Karma in https-only enviournment

Closes #1400

[maksimr]

@clexit Thanks!

Are you use https proxy?
Because karma run http server.

[ghost]

Hi @maksimr!

Yes, it's https that proxies to the local Karma instance. Since there is only https, socket.io fails to connect because of the hardcoded protocol (it tries to connect from https to the nonexistent http). While local http Karma is ok, we cannot configure http proxy due to security restrictions.

Can this change be merged? I've just noticed that the tag in the commit message might be incorrect. Does it matter for merge?

[maksimr]

@clexit

Can this change be merged?

Yes, I think it's good change!

I've just noticed that the tag in the commit message might be incorrect. Does it matter for merge?

What tag? cli?

I think will be better change scope to client, because cli usual mean command line interface

fix(client): ...

Thanks

[ghost]

Cool, thanks!

I changed the scope tag to client. The history should be OK now.

[maksimr]

@clexit Thanks

LGTM

[dignifiedquire]

LGTM

[maksimr]

#merge

[karmarunnerbot]

Sent to presubmit as presubmit-master-pr-1401

[maksimr]

#merge

[zzo]

#merge

[karmarunnerbot]

Sent to presubmit as presubmit-master-pr-1401

[dignifiedquire]

#merge

[karmarunnerbot]

Sent to presubmit as presubmit-master-pr-1401