feat(launcher): Enable specification of retry-limit #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -265,6 +265,7 @@ var Config = function () { | |||
| this.browserNoActivityTimeout = 10000 | |||
| this.concurrency = Infinity | |||
| this.failOnEmptyTestSuite = true | |||
| this.retryLimit = 1 | |||
There was a problem hiding this comment.
Yes
On Thu, Jan 21, 2016, 10:29 Friedel Ziegelmayer notifications@github.com
wrote:
In lib/config.js
#1815 (comment):@@ -265,6 +265,7 @@ var Config = function () {
this.browserNoActivityTimeout = 10000
this.concurrency = Infinity
this.failOnEmptyTestSuite = true
- this.retryLimit = 1
This should be 2 right?
—
Reply to this email directly or view it on GitHub
https://github.com/karma-runner/karma/pull/1815/files#r50376873.
|
This looks good to me, could you squash the last commit into the first please? |
Allow specification of retry limit in configuration file with the `retryLimit` property. Closes karma-runner#1126
budde377
force-pushed
the
feature-allow-configuration-for-retryLimit
branch
from
4b42dc8
to
cc5547c
Compare
|
Done |
|
Thanks |
dignifiedquire
added a commit
that referenced
this pull request
Jan 22, 2016
…r-retryLimit feat(launcher): Enable specification of retry-limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specification of retry limit in configuration file with the
retryLimitproperty.I also reordered the entries in the documentation in alphabetical order.
Closes #1126