Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reporter): Disable source maps for URLs without line number #1915

Conversation

davidparsson
Copy link
Contributor

There is no way to resolve source maps in this case anyway. Fixes #1274.

There is no way to resolve them in this case anyway. Fixes karma-runner#1274.
@dignifiedquire
Copy link
Member

Thanks :octocat: waiting for travis to do it's thing

@davidparsson
Copy link
Contributor Author

Is that Travis failure really related to my changes? I find that hard to believe.

@dignifiedquire
Copy link
Member

Is that Travis failure really related to my changes? I find that hard to believe.

No, just Travis being slow :(

@dignifiedquire dignifiedquire removed their assignment Feb 18, 2016
dignifiedquire added a commit that referenced this pull request Feb 18, 2016
…ce-map

fix(reporter): Disable source maps for URLs without line number
@dignifiedquire dignifiedquire merged commit c3f00c7 into karma-runner:master Feb 18, 2016
@davidparsson davidparsson deleted the fix/no-line-number-no-source-map branch February 18, 2016 17:36
@IgorAufricht
Copy link

Hi, thanks for the fix. When can we expect this to be released? It has been merged for 3 months, but there hasn't been any release of karma, so the fix is not available to use. Thanks!

@CrlsMrls
Copy link

CrlsMrls commented Jun 24, 2016

we are also expecting this change, when will be this released?

@dignifiedquire
Copy link
Member

@carlos- this is available in 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks source map if error message contain url without line number and column
4 participants