Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): Enable loading different file types when running in parent mode without iframe #3289

Merged
merged 8 commits into from Apr 12, 2019
Merged

fix(client): Enable loading different file types when running in parent mode without iframe #3289

merged 8 commits into from Apr 12, 2019

Commits on Mar 20, 2019

  1. fix(client): Includes attributes like type in script tags when runnin… 

    …g in parent mode without iframe

Back in karma-runner#2542, a third option to run tests without iframe is implemented, mostly for lightweight browser. This fix is to include file type so files like .css would able to load properly.
    @chan1cyrus2
    chan1cyrus2 committed Mar 20, 2019
    Copy the full SHA
    d39167c View commit details
    Browse the repository at this point in the history

  2. fix(client): Enable loading different file types when running in pare… 

    …nt mode without iframe

Back in karma-runner#2542, a third option to run tests without iframe is implemented, mostly for lightweight browser. It only allows script element to be loaded dynamically. This fix includes file type like .css to be loaded properly.
    @chan1cyrus2
    chan1cyrus2 committed Mar 20, 2019
    Copy the full SHA
    cd0bf3c View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. fix(client): Update comments on escaping character with special roles… 

    … in HTML
    @chan1cyrus2
    chan1cyrus2 committed Mar 22, 2019
    Copy the full SHA
    5fd685a View commit details
    Browse the repository at this point in the history

  2. fix(client): Fix comments

    @chan1cyrus2
    chan1cyrus2 committed Mar 22, 2019
    Copy the full SHA
    699f8a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. fix(client): Use conditions to make the require changes. 

    Add conditions to check whether it is serving client_with_context.html to construct the scriptUrl

Fixes karma-runner#3289
    “Cyrus committed Apr 12, 2019
    Copy the full SHA
    cddb93c View commit details
    Browse the repository at this point in the history

  2. fix(client): Fix CLA 

    Fixes karma-runner#3289
    @chan1cyrus2
    chan1cyrus2 committed Apr 12, 2019
    Copy the full SHA
    43d9629 View commit details
    Browse the repository at this point in the history

  3. fix(client): Fix CLA second try! 

    Fixes karma-runner#3289
    @chan1cyrus2
    chan1cyrus2 committed Apr 12, 2019
    Copy the full SHA
    905e464 View commit details
    Browse the repository at this point in the history

  4. fix(client): Fix typo 

    Fixes karma-runner#3289
    @chan1cyrus2
    chan1cyrus2 committed Apr 12, 2019
    Copy the full SHA
    e87e349 View commit details
    Browse the repository at this point in the history