Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler): add a bundler layer #3638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnjbarton
Copy link
Contributor

The input config supplies 'patterns' which FileList expands into Files.
These files are preprocessed and then 'file-list-modified' is fired.
The event offers a pair of file lists, {included, served}.
The bundle layer maps this pair to a new pair where fewer files are included.
By default the bundler copies the inputs to outputs.

The bundled files are stored on currentWebFiles which replaces
the FileList.files in the middleware/karma.

Fixes #3633

@AppVeyorBot
Copy link

Build karma 2898 failed (commit e70a216f03 by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 501 failed (commit e70a216f03 by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 500 failed (commit e70a216f03 by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 502 completed (commit 0974963617 by @johnjbarton)

@AppVeyorBot
Copy link

Build karma 2899 completed (commit 0974963617 by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 501 completed (commit 0974963617 by @johnjbarton)

jginsburgn
jginsburgn previously approved these changes Jan 27, 2021
@@ -82,7 +83,10 @@ class Server extends KarmaEventEmitter {
webServer: ['factory', createWebServer],
serveFile: ['factory', createServeFile],
serveStaticFile: ['factory', createServeStaticFile],
// Obsolete, do not use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can display a warning when people use this?

@codymikol
Copy link

I actually was just about to make this feature request and to my surprise here it is 💯

The input config supplies 'patterns' which FileList expands into Files.
These files are preprocessed and then 'file-list-modified' is fired.
The event offers a pair of file lists, {included, served}.
The bundle layer maps this pair to a new pair where fewer files are included.
By default the bundler copies the inputs to outputs.

The bundled files are stored on currentWebFiles which replaces
the FileList.files in the middleware/karma.
@karmarunnerbot
Copy link
Member

Build karma 526 completed (commit e6fb540a43 by @johnjbarton)

@AppVeyorBot
Copy link

Build karma 2923 completed (commit e6fb540a43 by @johnjbarton)

@AppVeyorBot
Copy link

Build karma 2924 completed (commit 30d894ad1a by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 525 completed (commit e6fb540a43 by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 527 completed (commit 30d894ad1a by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 526 completed (commit 30d894ad1a by @johnjbarton)

@jginsburgn jginsburgn force-pushed the master branch 12 times, most recently from 6fe6df0 to 56cda53 Compare October 20, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Introduce a "bundle" step in the file processing pipeline.
5 participants