feat(server): remove socket reconnect support #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build karma 531 completed (commit 801e167977 by @johnjbarton) |
|
✅ Build karma 530 completed (commit 801e167977 by @johnjbarton) |
|
✅ Build karma 2928 completed (commit 801e167977 by @johnjbarton) |
|
✅ Build karma 2979 completed (commit 3139506d62 by @johnjbarton) |
|
✅ Build karma 582 completed (commit 3139506d62 by @johnjbarton) |
|
✅ Build karma 581 completed (commit 3139506d62 by @johnjbarton) |
This feature has been trouble and there are cases it cannot work. Any socket disconnect during a test can lose data. The server will disconnect if the client does not reply. Combined it makes any long running or large test error prone. Better to bail and restart the test. Fixes karma-runner#3652
|
✅ Build karma 2980 completed (commit e9b1057bed by @johnjbarton) |
|
✅ Build karma 583 completed (commit e9b1057bed by @johnjbarton) |
|
✅ Build karma 582 completed (commit e9b1057bed by @johnjbarton) |
jginsburgn
force-pushed
the
master
branch
13 times, most recently
from
b9831cc
to
e9e795c
Compare
jginsburgn
force-pushed
the
master
branch
6 times, most recently
from
6fe6df0
to
56cda53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has been trouble and there are cases it cannot work.
Any socket disconnect during a test can lose data. The server will disconnect
if the client does not reply. Combined it makes any long running or large
test error prone. Better to bail and restart the test.
Fixes #3652