Updated socket.io version to fix security issues with socket.io-parser and engine.io #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sharmanikhil04
changed the title
|
@jginsburgn Can you please have a look at this PR ? |
|
@juliemr Can you please have a look at this PR ? |
|
@barrtender Can you please have a look at this PR ? |
pmvald
previously approved these changes
Feb 5, 2024
pmvald
force-pushed
the
feature/dependencyupdates
branch
3 times, most recently
from
ae4eeba
to
297255f
Compare
…cket.io-parser and engine.io A specially crafted Sokcet.IO packet can trigger an uncaught exception on Sokcet.IO Server , thus killing the Node.js process. Similarly, a specially crafted HTTP request can trigger an uncaught exception on the Engine.IO server, thus killing the Node.js process. These are potential security risks which are introduced by using socket.io@4..4.1 and need to be addressed in order to maintain the security of applications using karma.
pmvald
force-pushed
the
feature/dependencyupdates
branch
from
297255f
to
fc71bf2
Compare
pmvald
approved these changes
Feb 5, 2024
|
🎉 This PR is included in version 6.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A specially crafted Sokcet.IO packet can trigger an uncaught exception on Sokcet.IO Server , thus killing the Node.js process.
Refer CWE-754 : https://cwe.mitre.org/data/definitions/754.html , CWE-20 : https://cwe.mitre.org/data/definitions/20.html , CVE-2023-32695 : https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-32695 )
Similarly, a specially crafted HTTP request can trigger an uncaught exception on the Engine.IO server, thus killing the Node.js process. (Refer CWE-248 : https://cwe.mitre.org/data/definitions/248.html, CVE-2023-31125 : https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-31125)
These are potential security risks which are introduced by using socket.io@4..4.1 and need to be addressed in order to maintain the security of applications using karma.