New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to vue-query #2567
Migrate to vue-query #2567
Conversation
Quite rough at the moment, lots of broken bits
useRouteParam had concurrency issues when using it for multiple params
This PR is a bit crazy, sorry! It's a bit of a creative exploration. It's a bit like when I rearrange a room, just start pulling all the furniture out, moving things around, there is a crazy chaos for a while, then slowly the new form emerges... My progress is quite good though. If it was needed to make a more incremental PR, I could extract some parts out to another PR, but I'll carry on with this way for now. |
need to remove from backend as well
Branch deployment URL: https://add-more-vue-query.dev.karrot.world
What does this PR do?
This switches our frontend data layer from vuex to vue-query.
There were a few motivations for this:
One of the complexities of the existing data layer is passing values down through many layers of components. We did originally have a philosophy of props in, events out for components, so they would be usable in isolation, but this pushed a lot of abstract complexity to the data layer. The data that the components needed would have to be managed far away from those components in the stores.
So, a new approach!
isCurrentUser
)This also has a big impact on testing strategy, that is dealt with over here --> #2536
TODO
This is a slightly daunting list of the modules (
src/*/datastore/*.js
) to convert over.Links to related issues
Checklist