runtime-rs: Fix constructing the RTC struct #9571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beraldoleal
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Hi @emanuellima1 thanks for this.
Please add a brief description to the commit description, explaining what was wrong and why this is needed.
Also a minor (maybe nit) suggestion is to use commit hash references instead of a PR reference.
pmores
approved these changes
May 7, 2024
There was a problem hiding this comment.
LGTM, thanks @emanuellima1 ! I do consider @beraldoleal 's comments relevant though so please take them into account if possible.
RTC was being built in a wrong fashion on commit #2bc5e3c6e2ab0145fa9e8be95df0d5086c07a517 RTC was being constructed inside the QemuCmdLine struct, but it should've been built inside the devices vector. Signed-off-by: Emanuel Lima <emlima@redhat.com>
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTC was being built in a wrong fashion on PR 9519