runtime-rs: Use add_task_by_tgid for constrain_hypervisor #9572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime-rs `CgroupsResource.constrain_hypervisor` used `add_task` instead of `add_task_by_tgid` when adding the hypervisor threads to the cgroup. This causes an issue due to the default type of the cgroup being `domain` instead of `threaded` or `domain threaded` and throws the error: `using method in wrong cgroup mode`. CgroupsResource.new already uses `add_task_by_tgid` so this change should be fine Fixes: kata-containers#8245 Signed-off-by: Champ-Goblem <cameron@northflank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime-rs
CgroupsResource.constrain_hypervisorusedadd_taskinstead ofadd_task_by_tgidwhen adding the hypervisor threads to the cgroup.This causes an issue due to the default type of the cgroup being
domaininstead ofthreadedordomain threadedand throws the error:using method in wrong cgroup mode.CgroupsResource.new already uses
add_task_by_tgidso this change should be fineFixes: #8245