kata-agent: Add CDI support #9584
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvonkok
commented
May 2, 2024
| return Ok(()); | ||
| } | ||
|
|
||
| match tokio::process::Command::new("/usr/bin/cdi") |
There was a problem hiding this comment.
This needs to be replaced with proper Rust implementation of CDI. For now using a go binary to do the proper injection of devices. Until then this PR remains a draft.
There was a problem hiding this comment.
Hi Zvonko, does just execute cmd cdi raw_oci_config cdi_oci_config enough ? there's no such usage of cdi when I try to execute /usr/bin/cdi. Is it some specified version of cdi ?
There was a problem hiding this comment.
This is a stripped down version of cdi but we could use the official one.
For proper device handling add CDI support Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok
added
wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For proper device handling add CDI support