runtime-rs: Add pci_hotplug as a config option #9595
Conversation
|
/test |
| # PCI hotplug | ||
| # Enable or disable pci_hotplug | ||
| # will be set to @DEFPCIHOTPLUG@ | ||
| pci_hotplug = @DEFPCIHOTPLUG@ |
There was a problem hiding this comment.
could you add a comment here that this currently is a dragonball-only config, so that other people could know that this config won't take effect on other VMMs?
| pub pci_hotplug: bool, | ||
|
|
There was a problem hiding this comment.
could you add a comment here that this currently is a dragonball-only config, so that other people could know that this config won't take effect on other VMMs?
ananos
force-pushed
the
feat_config_pci_hotplug
branch
from
592966c
to
17e3391
Compare
There are cases where enabling PCI hotplug by default, breaks Dragonball's initial setup [see kata-containers#9596], resulting in the following error message: ``` FATA[0000] failed to create shim task: Others("failed to handle message try init runtime instance\n\nCaused by:\n 0: init runtime handler\n 1: start sandbox\n 2: start vm\n 3: start vmm instance\n 4: Failed to start vmm\n 5: Failed to start MicroVm\n 6: vmm action error: StartMicroVm(CreateVfioDevice(NoResource))"): unknown ``` Adding this as a config option enables normal booting even on nodes that lack the default functionality. Fixes: kata-containers#9509 Signed-off-by: Anastassios Nanos <ananos@nubificus.co.uk>
ananos
force-pushed
the
feat_config_pci_hotplug
branch
from
17e3391
to
9781a44
Compare
|
For CI failures for s390x, I am working on it and will get it green again. Sorry for the inconvenience. UPDATE: all CI jobs for s390x have been passed. |
|
We should try to keep the discrepancies between dragonball and other VMMs as small as possible. To not introduce too many different configs variables. For qemu/CLH e.g. we have hot_plug_vfio="..." or cold_plug_vfio="...". |
|
/test |
|
I tend to agree to ditch this PR. My only thought is whether we would be interested in keeping this option in terms of "faster" booting maybe? Off the top of my head, removing the PCI hotplug initialization part when the user knows it is not needed, could save some time; so it might be useful to some people.. Not sure though -- any thoughts on this? |
There are cases where enabling PCI hotplug by default, breaks
Dragonball's initial setup [see #9596], resulting in the following
error message:
Adding this as a config option enables normal booting even on nodes that
lack the default functionality.
Fixes: #9509