Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kata-agent: update env PCIDEVICE_<prefix>_<resource-name>_INFO #9605

Merged
merged 1 commit into from May 23, 2024
Merged

kata-agent: update env PCIDEVICE_<prefix>_<resource-name>_INFO #9605

merged 1 commit into from May 23, 2024

Conversation

l8huang
Copy link

@l8huang l8huang commented May 7, 2024 •
edited

The new version of sriov-network-device-plugin adds an env PCIDEVICE_<prefix>_<resource-name>_INFO, which has a json value; kata-agent can't parse it as env PCIDEVICE_<prefix>_<resource-name> which has value in format "DDDD:BB:SS.F".

This change updates env PCIDEVICE_<prefix>_<resource-name>_INFO.

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label May 7, 2024
@Apokleos Apokleos mentioned this pull request May 9, 2024
Open
@lifupan lifupan mentioned this pull request May 15, 2024
Open
@l8huang l8huang changed the title kata-agent: skip update env PCIDEVICE_<prefix>_<resource-name>_INFO kata-agent: update env PCIDEVICE_<prefix>_<resource-name>_INFO May 20, 2024
lifupan
lifupan approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@lifupan lifupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kata-agent: update env PCIDEVICE_<prefix>_<resource-name>_INFO
b0a91b0 
The new version of sriov-network-device-plugin adds an env
`PCIDEVICE_<prefix>_<resource-name>_INFO`, which has a json
value; kata-agent can't parse it as env
`PCIDEVICE_<prefix>_<resource-name>` which has value in format
"DDDD:BB:SS.F".

This change updates env `PCIDEVICE_<prefix>_<resource-name>_INFO`.

Signed-off-by: Lei Huang <leih@nvidia.com>
@l8huang
Copy link
Author

l8huang commented May 21, 2024 •
edited

updated PR to fix cargo fmt -- --check

sorry for unintentionally rebased the PR, I reverted the rebase and pushed again, please use
https://github.com/kata-containers/kata-containers/compare/b973db29910d2b5f97f8c966c63e939272249e33..b0a91b0d13844e10d4de982a9744462510192d6c to review the changes.

@l8huang l8huang mentioned this pull request May 21, 2024
Open
@Apokleos
Copy link
Contributor

/test

zvonkok
zvonkok approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@zvonkok zvonkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zvonkok zvonkok merged commit 3affd83 into kata-containers:main May 23, 2024
284 of 301 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvonkok zvonkok zvonkok approved these changes

@lifupan lifupan lifupan approved these changes

Assignees
No one assigned
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@l8huang @Apokleos @zvonkok @lifupan @katacontainersbot