Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: Add build targets for GPU rootfs initrd/image #9618

Merged
merged 1 commit into from May 15, 2024

Conversation

zvonkok
Copy link
Contributor

@zvonkok zvonkok commented May 10, 2024

Preparation for complete GPU rootfs build step num 1 of N

@katacontainersbot katacontainersbot added the size/small Small and simple task label May 10, 2024
Preparation for complete GPU rootfs build step #1/#N

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
@zvonkok
Copy link
Contributor Author

zvonkok commented May 10, 2024

/test

Comment on lines +419 to +420
export AGENT_POLICY="yes"
export AGENT_INIT="yes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fidencio and/or @danmihai1 can probably confirm, but with the regorus crate and follow on changes I'm not sure if AGENT_POLICY="yes" (as it defaults to yes now) and AGENT_INIT="yes" are strictly required to use policy, but equally I don't think it's and issue to have them set as a double measure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more to amplify and show that be it image or initrd we're always using AGENT_INIT and AGENT_POLICY I think it does not "hurt".

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@zvonkok zvonkok merged commit 117e2f2 into kata-containers:main May 15, 2024
304 of 362 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants