New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpu: Add build targets for GPU rootfs initrd/image #9618
Conversation
Preparation for complete GPU rootfs build step #1/#N Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
/test |
export AGENT_POLICY="yes" | ||
export AGENT_INIT="yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fidencio and/or @danmihai1 can probably confirm, but with the regorus crate and follow on changes I'm not sure if AGENT_POLICY="yes"
(as it defaults to yes
now) and AGENT_INIT="yes"
are strictly required to use policy, but equally I don't think it's and issue to have them set as a double measure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is more to amplify and show that be it image or initrd we're always using AGENT_INIT and AGENT_POLICY I think it does not "hurt".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Preparation for complete GPU rootfs build step num 1 of N