simple insert_dict() builder #725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wd60622
reviewed
Feb 21, 2024
edvardm
force-pushed
the
master
branch
2 times, most recently
from
1761de8
to
9480180
Compare
in SQL builders, order of calling individual functions should not matter. Originally it was allowed to first call columns() and then insert_dict as long as the two matched, but I'm not even sure it worked, as we should have used set comparison instead. It is also better to have symmetric API in
wd60622
reviewed
Feb 26, 2024
|
Sorry for the delay, some quite tragic happened at work and forgot about this for some time. Hopefully resolved noted issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
insert_dict()for QueryBuilder instancescolumns()while usinginsert_dict()Idea pretty much the same as in issue #533 :
Given how it's implemented, maybe
from_dict()would be more suitable, asinto()is already part of context? Multi-value inserts are trickier though, as they seem to vary between enginesEdit:
Query.intoin tests