Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escapeParameterHtml flag: Don't escape ampersand #1019 #1020

Merged

Conversation

gardarh
Copy link
Contributor

@gardarh gardarh commented Oct 19, 2020

This PR implements the changes proposed in issue #1019 - avoid escaping the ampersand symbol when the flag is raised.

@codecov-io
Copy link

Codecov Report

Merging #1020 into v8.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v8.x    #1020   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files          10       10           
  Lines         913      913           
=======================================
  Hits          881      881           
  Misses         32       32           
Impacted Files Coverage Δ
src/util.js 98.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae03ab...764d2b9. Read the comment docs.

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@kazupon kazupon added the Type: Breaking Includes backwards-incompatible fixes label Oct 19, 2020
@kazupon kazupon merged commit 413bd54 into kazupon:v8.x Oct 19, 2020
kazupon added a commit to intlify/vue-i18n-next that referenced this pull request Oct 19, 2020
kazupon added a commit to intlify/vue-i18n-next that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged Type: Breaking Includes backwards-incompatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants