Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: number format keys missing compared the Intl.Number object #1048

Merged
merged 2 commits into from Nov 18, 2020

Conversation

jevillard
Copy link
Contributor

Suggested fix for #1047

@jevillard
Copy link
Contributor Author

Hello @kazupon,

I don't understand why the e2e tests were not successful because the problem seems to be related to a session or Chrome driver error...
https://app.circleci.com/pipelines/github/kazupon/vue-i18n/379/workflows/f089ce4c-1fdf-409d-a5d5-3a7484901686/jobs/1614

Do you have an idea? Thanks 😃

@jevillard
Copy link
Contributor Author

Reopen the PR after adding the documentation

@jevillard jevillard reopened this Nov 18, 2020
@jevillard jevillard marked this pull request as ready for review November 18, 2020 12:14
@kazupon
Copy link
Owner

kazupon commented Nov 18, 2020

@jevillard
Thank you for your PR!

In about e2e, We can resolve this issue, when we update chromedriver@86.0.0.

"chromedriver": "^85.0.0",

@jevillard
Copy link
Contributor Author

@kazupon
Thank you for your reply! I fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants