Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvemation #1104

Merged
merged 24 commits into from Jan 17, 2021
Merged

Documentation improvemation #1104

merged 24 commits into from Jan 17, 2021

Conversation

lucasferreiralimax
Copy link
Contributor

  • Reflection information in legacy, api, installation, homepage.
  • Reduce SVG
  • Addition alt in images
  • Style in images for max-width and resize page

@kazupon i believe this good for upgrade, code review please.

vuepress/README.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #1104 (a5a0bbd) into v8.x (92a54e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v8.x    #1104   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files          10       10           
  Lines         913      913           
=======================================
  Hits          881      881           
  Misses         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a54e7...a5a0bbd. Read the comment docs.

Copy link
Contributor Author

@lucasferreiralimax lucasferreiralimax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kazupon i addition some reviews for information in docs chinese please review all translate.

In style scoped i addition more examples with ::v-deep and /deep/

vuepress/README.md Outdated Show resolved Hide resolved
vuepress/pt/README.md Show resolved Hide resolved
vuepress/ru/README.md Show resolved Hide resolved
vuepress/zh/README.md Show resolved Hide resolved
vuepress/zh/guide/tooling.md Show resolved Hide resolved
vuepress/zh/guide/locale.md Show resolved Hide resolved
vuepress/zh/guide/lazy-loading.md Show resolved Hide resolved
vuepress/zh/guide/hot-reload.md Show resolved Hide resolved
vuepress/zh/guide/fallback.md Show resolved Hide resolved
vuepress/zh/guide/component.md Show resolved Hide resolved
@kazupon
Copy link
Owner

kazupon commented Jan 17, 2021

@lucasferreiralimax
Thank you for your imorovemention!

There are a few review points about Chinese, but I think they are OK, so I would like to merge them once.
If there are any problems, I think that vue-i18n docs get feedback in the PR.

@lucasferreiralimax
Copy link
Contributor Author

lucasferreiralimax commented Jan 17, 2021

@lucasferreiralimax
Thank you for your imorovemention!

There are a few review points about Chinese, but I think they are OK, so I would like to merge them once.
If there are any problems, I think that vue-i18n docs get feedback in the PR.

Very good 👍🏽
I too agree with you

@kazupon kazupon merged commit 6c0c3b0 into kazupon:v8.x Jan 17, 2021
This was referenced Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants