Grammar fix for Installing vue-i18n-loader #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
requested changes
Jun 5, 2021
There was a problem hiding this comment.
Thank you for your contribution!
Sorry, late my response.
docs directory is generated with vuepress from vuepress directory
Could you fix the below docs, please? 🙏
https://github.com/kazupon/vue-i18n/blob/v8.x/vuepress/guide/sfc.md
Undoing to make the change in the correct spot :)
Apply changes to generating document :)
|
Ahh, I see - that was a lot easier to edit than the I reverted the changes in the |
kazupon
approved these changes
Jun 9, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sentence "You need to install vue-loader and vue-i18n-loader due to use custom blocks." makes more sense as either
I favored the first option since it sounded more natural to me and doesn't have a slight shift in tense :)