Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - Update @kazupon/vue-i18n-loader to @intlify/vue-i18n-loader #1267

Merged
merged 4 commits into from Jun 9, 2021

Conversation

fbigand
Copy link
Contributor

@fbigand fbigand commented Jun 5, 2021

When installing vue-i18n-loader for my project, following the documentation, I had this message
@kazupon/vue-i18n-loader@0.5.0: WARNING: If you would like to use @kazupon/vue-i18n-loader that is released new features and bug fixes, you need to install @intlify/vue-i18n-loader

After looking at the github project, I found that the command to run is this one npm i --save-dev @intlify/vue-i18n-loader@next.

So I changed the command, and references to @kazupon/vue-i18n-loader with @intlify/vue-i18n-loader

@fbigand fbigand changed the title Documentation - Update install vue-i18n-loader command Documentation - Update @kazupon/vue-i18n-loader to @intlify/vue-i18n-loader Jun 5, 2021
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Sorry, late my response.
docs directory is generated with vuepress from vuepress directory
Could you fix the below docs, please? 🙏

https://github.com/kazupon/vue-i18n/blob/v8.x/vuepress/guide/sfc.md

@fbigand
Copy link
Contributor Author

fbigand commented Jun 8, 2021

Thank you for this indication and sorry for late response.

I updated the pull request with changes on the file in vuepress folder.
I additionally updated the links to the github folder.
Since the html files are generated, I left my original commits, let me know if this need to be reverted.

Also, I am not entirely sure if this needs to be changed, (sfc.md, line 178, Laravel-Mix paragraph).
// The below code will inject i18n Kazupon/vue-18-loader as a loader for .vue files.

@kazupon kazupon merged commit 99a84c4 into kazupon:v8.x Jun 9, 2021
@kazupon kazupon added the Type: Documentation A documetation fixes label Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants