Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix datetime and number format fallbacking #858

Merged
merged 1 commit into from Apr 25, 2020
Merged

fix datetime and number format fallbacking #858

merged 1 commit into from Apr 25, 2020

Conversation

kazupon
Copy link
Owner

@kazupon kazupon commented Apr 25, 2020

closes #852

@kazupon kazupon added the Type: Bug Bug or Bug fixes label Apr 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #858 into v8.x will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v8.x     #858      +/-   ##
==========================================
+ Coverage   96.41%   96.45%   +0.04%     
==========================================
  Files          10       10              
  Lines         864      874      +10     
==========================================
+ Hits          833      843      +10     
  Misses         31       31              
Impacted Files Coverage Δ
src/components/number.js 100.00% <100.00%> (ø)
src/index.js 97.93% <100.00%> (+0.04%) ⬆️
src/util.js 98.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea111b...abc732d. Read the comment docs.

@kazupon kazupon merged commit 4ef365e into v8.x Apr 25, 2020
@kazupon kazupon deleted the fix/fallbacking branch April 25, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number and DateTime Formatting does not work for an fallbackLocale Array with multiple entries
2 participants