New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow component interpolation without root element #878
Allow component interpolation without root element #878
Conversation
Thank you for your PR!
My recommendation is that backwards compatibility can be maintained by also supporting boolean types. when passed boolean value ( The same goes for |
That makes sense. Would you want to work on the additional changes to the documentation, |
if
if
I'm busy developing for vue-i18n-next, so I'm glad if you could help. 🙏 |
Component without a root element can now be enabled by setting the tag prop to false. Fixes #876
I changed the behavior for |
Codecov Report
@@ Coverage Diff @@
## v8.x #878 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 10 10
Lines 885 886 +1
=======================================
+ Hits 853 854 +1
Misses 32 32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Don't delete _i18n in beforeDestroy (kazupon/vue-i18n#880): Avoid that translations in long-running methods throw on translations after destruction. Allow component interpolation without root element (kazupon/vue-i18n#878): For fixed responsiveness of the mobile checkout cancel button.
Don't delete _i18n in beforeDestroy (kazupon/vue-i18n#880): Avoid that translations in long-running methods throw on translations after destruction. Allow component interpolation without root element (kazupon/vue-i18n#878): For fixed responsiveness of the mobile checkout cancel button.
Don't delete _i18n in beforeDestroy (kazupon/vue-i18n#880): Avoid that translations in long-running methods throw on translations after destruction. Allow component interpolation without root element (kazupon/vue-i18n#878): For fixed responsiveness of the mobile checkout cancel button.
Don't delete _i18n in beforeDestroy (kazupon/vue-i18n#880): Avoid that translations in long-running methods throw on translations after destruction. Allow component interpolation without root element (kazupon/vue-i18n#878): For fixed responsiveness of the mobile checkout cancel button.
Don't delete _i18n in beforeDestroy (kazupon/vue-i18n#880): Avoid that translations in long-running methods throw on translations after destruction. Allow component interpolation without root element (kazupon/vue-i18n#878): For fixed responsiveness of the mobile checkout cancel button.
Component interpolation without a root element can now be enabled
by setting the tag prop to false.
Let me know if you prefer something else then value
false
, for examplea keyword like
"none"
.Value false would need to be specified as
:tag="false"
, a keyword astag="none"
which might read a little nicer.Fixes #876