Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix v-t pluralisation when choice is 0 #882

Merged
merged 2 commits into from May 19, 2020

Conversation

mikejacoutot
Copy link
Contributor

the directive was displaying the entire string instead of the correct pluralisation

@codecov-io
Copy link

Codecov Report

Merging #882 into v8.x will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             v8.x     #882      +/-   ##
==========================================
- Coverage   96.38%   96.38%   -0.01%     
==========================================
  Files          10       10              
  Lines         886      885       -1     
==========================================
- Hits          854      853       -1     
  Misses         32       32              
Impacted Files Coverage Δ
src/components/interpolation.js 100.00% <ø> (ø)
src/components/number.js 100.00% <ø> (ø)
src/directive.js 92.98% <ø> (ø)
src/mixin.js 94.73% <ø> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179f0b1...fccd7f2. Read the comment docs.

@exoego
Copy link
Collaborator

exoego commented May 18, 2020

Thanks !!
Could you consider to add test case(s) for this behavior ?

@kazupon kazupon added the Type: Bug Bug or Bug fixes label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants