Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flow types and enable flow types testing on CI #896

Merged
merged 2 commits into from
May 27, 2020
Merged

Fix flow types and enable flow types testing on CI #896

merged 2 commits into from
May 27, 2020

Commits on May 27, 2020

  1. Fix broken unit tests 

    The tests were using "assert" function wrong.
"assert" is defined as: assert(value, [message])

The tests passed two arguments in an attempt to compare them while
the only thing that happened was that the first value was checked for
being truthy.
    @rchl
    rchl committed May 27, 2020
    Configuration menu
    Copy the full SHA
    60fbd6e View commit details
    Browse the repository at this point in the history

  2. Fix flow types and enable flow testing on CI 

    Types fixed by making "getChoiceIndex" method follow types and be
a class property rather than class method. Class methods are "read-only"
in flow and that wasn't compatible with flow types that are defining
that function as a property (to allow overriding through prototype changing).
    @rchl
    rchl committed May 27, 2020
    Configuration menu
    Copy the full SHA
    6fd1121 View commit details
    Browse the repository at this point in the history