Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link to API and Guide top level #920

Merged
merged 1 commit into from Jun 12, 2020

Conversation

AleksandrSl
Copy link
Contributor

@AleksandrSl AleksandrSl commented Jun 11, 2020

We don't have many options in Learn section, and API reference hidden beside select is hard to discover.
Similar solutions are made in vuex, vue router and so on.

#915

Previous version:
image

Proposed version:
image

We don't have many options in Learn section, and API reference hidden beside select is hard to discover.
Similar solutions are made in vuex, vue router and so on.
@AleksandrSl
Copy link
Contributor Author

Should I regenerate docs manually?

@codecov-commenter
Copy link

Codecov Report

Merging #920 into v8.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v8.x     #920   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          10       10           
  Lines         896      896           
=======================================
  Hits          864      864           
  Misses         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f6834...ba51684. Read the comment docs.

@exoego
Copy link
Collaborator

exoego commented Jun 11, 2020

@AleksandrSl
Great, thanks !!
Could you add screenshots to the PR description, so maintainers/users can glance the changes without hastle ? 🙏

@AleksandrSl
Copy link
Contributor Author

Of course!

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kazupon kazupon merged commit 31573e1 into kazupon:v8.x Jun 12, 2020
@kazupon kazupon added the Type: Documentation A documetation fixes label Jun 12, 2020
@exoego exoego mentioned this pull request Jun 17, 2020
@FrankyBoy
Copy link

Thanks a lot for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants