Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing quote #925

Merged
merged 2 commits into from Jun 22, 2020
Merged

Added missing quote #925

merged 2 commits into from Jun 22, 2020

Conversation

fschlag
Copy link
Contributor

@fschlag fschlag commented Jun 22, 2020

Added a missing quote for section Explicit fallback with an array of locales: en' changed to 'en'.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020

Codecov Report

Merging #925 into v8.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v8.x     #925   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          10       10           
  Lines         896      896           
=======================================
  Hits          864      864           
  Misses         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6787f...eb48a11. Read the comment docs.

@exoego
Copy link
Collaborator

exoego commented Jun 22, 2020

Thanks !!
Could you also fix missing quote in source file (markdown file): https://github.com/kazupon/vue-i18n/blob/v8.x/gitbook/en/fallback.md

@fschlag
Copy link
Contributor Author

fschlag commented Jun 22, 2020

Fixed there too.

@kazupon
Copy link
Owner

kazupon commented Jun 22, 2020

Good Catch!
Thanks!

@kazupon kazupon added the Type: Documentation A documetation fixes label Jun 22, 2020
@kazupon kazupon merged commit 6304c34 into kazupon:v8.x Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants