Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: message function #972

Merged
merged 2 commits into from Aug 13, 2020
Merged

feat: message function #972

merged 2 commits into from Aug 13, 2020

Conversation

kazupon
Copy link
Owner

@kazupon kazupon commented Aug 13, 2020

resolve #969

@pr-triage pr-triage bot added the PR: draft label Aug 13, 2020
@kazupon kazupon added the Type: Feature Includes new features label Aug 13, 2020
@kazupon kazupon mentioned this pull request Aug 13, 2020
Closed
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020 •
edited

Codecov Report

Merging #972 into v8.x will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v8.x     #972      +/-   ##
==========================================
+ Coverage   96.42%   96.46%   +0.03%     
==========================================
  Files          10       10              
  Lines         896      904       +8     
==========================================
+ Hits          864      872       +8     
  Misses         32       32
Impacted Files Coverage Δ
src/path.js 88.07% <ø> (ø)
src/index.js 97.82% <100.00%> (+0.03%) ⬆️
src/util.js 98.43% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992c402...2ace2d7. Read the comment docs.

philippevezina
philippevezina approved these changes Aug 13, 2020
View reviewed changes
Copy link

@philippevezina philippevezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the implementation :) It's what I was thinking about 👍

@kazupon kazupon marked this pull request as ready for review August 13, 2020 15:49
@kazupon kazupon merged commit 2ea18e0 into v8.x Aug 13, 2020
@kazupon kazupon deleted the feat/message-function branch August 13, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippevezina philippevezina philippevezina approved these changes

Assignees
No one assigned
Labels
PR: merged Type: Feature Includes new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allowing LocaleMessage to be Functions
3 participants
@kazupon @codecov-commenter @philippevezina