✨ Update to latest kcp, apimachinery, controller-runtime #30
Conversation
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @fgiloux. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fgiloux, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@fgiloux: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
New changes are detected. LGTM label has been removed. |
|
/remove-hold |
openshift-ci
bot
removed
the
do-not-merge/hold
fgiloux
force-pushed
the
bump
branch
2 times, most recently
from
3ce89ea
to
4f76624
Compare
Makefile
Outdated
| @@ -31,7 +31,7 @@ YQ ?= $(LOCALBIN)/yq | |||
| ## Tool Versions | |||
| KUSTOMIZE_VERSION ?= v3.8.7 | |||
| CONTROLLER_TOOLS_VERSION ?= v0.8.0 | |||
| KCP_VERSION ?= 0.7.5 | |||
| KCP_VERSION ?= 0.8.2 | |||
There was a problem hiding this comment.
Now that 0.9.0 is out, would you be willing to bump to that?
There was a problem hiding this comment.
Yes I can do that next week. I would need to bump controller-runtime dependencies as well and check that things are still working. Another point related is whether we want to rebase controller-runtime fork on a newer upstream version. I don't think it has been done since the fork was created ~5-6 months ago.
I would prefer doing it in separate PRs. Do you see it otherwise?
There was a problem hiding this comment.
The latest version of controller-runtime (0.13.0) has k8s 1.25 deps (https://github.com/kubernetes-sigs/controller-runtime/blob/v0.13.0/go.mod). But we do have 0.12.3 (https://github.com/kubernetes-sigs/controller-runtime/blob/v0.12.3/go.mod), which support k8s 1.24 and has a few bug fixes that could be useful.
There was a problem hiding this comment.
I am looking at that again. Actually kcp fork of controller-runtime is already on 0.12.3. I am testing with v0.9.1. If there is no issue I will push the change here.
There was a problem hiding this comment.
@ncdc tests were good I have pushed the change with v0.9.1
ncdc
changed the title
- kcp api v0.9.1 - apimachinery v0.0.0-20220922165458-607ac5e87531 - latest controller-runtime Signed-off-by: Frederic Giloux <fgiloux@redhat.com>
|
/test all |
|
/retest |
|
@fgiloux: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This bumps the example to the latest version of kcp controller-runtime and updates the kcp dependencies.
Signed-off-by: Frederic Giloux fgiloux@redhat.com