🐛 apibindings/reconciler/labeller: fix informer error on non-persisted resources #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note-none
sttts
force-pushed
the
sttts-claimable-sar-label-controller
branch
from
677700d
to
c58ce85
Compare
kcp-ci-bot
added
the
size/S
sttts
force-pushed
the
sttts-claimable-sar-label-controller
branch
from
c58ce85
to
d0f4469
Compare
|
/approve |
kcp-ci-bot
added
the
approved
…resources Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
sttts
force-pushed
the
sttts-claimable-sar-label-controller
branch
from
d0f4469
to
fa0bb7f
Compare
|
/retest |
|
Workspace deletion flake, unrelated. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 6136b8abec92db137d4954a7a78638d4800fad7f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since #3129, both
SubjectAccessReviewandLocalSubjectAccessReviewcan be claimed. But as these are not persisted, there is no need for labelling of objects. It's not even possible to create such an informer. Hence, skip these resources.Release Notes