Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 9.0 compatibility #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GHC 9.0 compatibility #129

wants to merge 2 commits into from

Conversation

sheaf
Copy link

@sheaf sheaf commented Jan 2, 2021

This patch adds GHC 9.0 support relative to generic-lens-1.2.0.1.
I'm still using this version of generic-lens as I make extensive use of constrained traversals, which were removed in the 2.0 release.

I couldn't find a suitable branch to apply this to, but this patch was done on top of e4f6890.

@anka-213
Copy link

anka-213 commented May 3, 2021

Now that #130 is merged, this can probably be closed.

@sheaf
Copy link
Author

sheaf commented May 3, 2021

This is a patch to generic-lens-1.2, not generic-lens-2.1. That means it's not superseded by #130.

@sheaf sheaf force-pushed the generic-lens-1 branch 3 times, most recently from 2c058b5 to 1dc0700 Compare January 9, 2022 12:38
@andreasabel
Copy link
Collaborator

@sheaf: The Gods have not heard your prayer, it seems. Is generic-lens-1 still relevant for you today? Maybe you have a fork?

@sheaf
Copy link
Author

sheaf commented Nov 23, 2023

@sheaf: The Gods have not heard your prayer, it seems. Is generic-lens-1 still relevant for you today? Maybe you have a fork?

Yes, it is relevant to me because I use the constrained traversals that generic-lens-1 provides. I have a fork here.

@michaelpj
Copy link
Collaborator

I think we would need to create a release branch in order to do this nicely. Is this still important to you @sheaf ?

@sheaf
Copy link
Author

sheaf commented Mar 29, 2024

I think we would need to create a release branch in order to do this nicely. Is this still important to you @sheaf ?

Yes, I am still using generic-lens-1 in several of my projects. The branch in this thread compiles on GHC 9.8 (although some version bumps might be necessary, I just used --allow-newer).

@sheaf
Copy link
Author

sheaf commented Mar 29, 2024

If you can provide a branch I would be happy to rebase the changes in this PR, perhaps with some additional changes to squash the current warnings. I'm not sure which newer commits might need to be backported (if any can be).

@michaelpj
Copy link
Collaborator

Do the things you need have to be in generic-lens? I wonder if it would be simpler for you to maintain your own package that just added the things that you need, then you could use newer generic-lens also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants