Refactoring: getting tables columns #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrajodas
changed the title
|
změnil jsem postup pro načítání názvů sloupečků a dat:
|
ondrajodas
commented
Apr 6, 2022
| @@ -21,7 +21,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
| && /tmp/composer-install.sh | |||
|
|
|||
| # Install and configure the C implementation of Protobuf extension if needed. | |||
| RUN pecl install protobuf; echo 'extension=protobuf.so' >> $PHP_INI_DIR/conf.d/protobuf.ini; | |||
| RUN pecl install protobuf-3.19.4; echo 'extension=protobuf.so' >> $PHP_INI_DIR/conf.d/protobuf.ini; | |||
There was a problem hiding this comment.
je nová verze protobuf která ale nefunguje
protocolbuffers/protobuf#9724
| private const USER_TABLES_STRUCTURE = [ | ||
| self::CUSTOMER_TABLE => [ | ||
| 'primaryKeys' => ['id'], | ||
| 'columns' => [ |
There was a problem hiding this comment.
columns už nepotřebuju - stahuju z query
Comment on lines
-86
to
-87
| $csvCustomer = new CsvWriter(sprintf('%s/out/tables/%s.csv', $this->dataDir, self::CUSTOMER_TABLE)); | ||
| $csvCampaign = new CsvWriter(sprintf('%s/out/tables/%s.csv', $this->dataDir, self::CAMPAIGN_TABLE)); |
There was a problem hiding this comment.
přesunuto do vlastních metod customers/campaigns
| @@ -120,47 +82,9 @@ public function extract(): void | |||
| )); | |||
| } | |||
| } | |||
|
|
|||
| // Create manifest for Customer | |||
There was a problem hiding this comment.
přesunuto do vlastních metod customers/campaigns
| $columnData = $data; | ||
| foreach (explode('.', $columnKey) as $key) { | ||
| if (!array_key_exists($key, $columnData)) { | ||
| $output[$columnName] = null; |
There was a problem hiding this comment.
data pro sloupeček neexistují => null
| $column = implode('.', $column); | ||
| } | ||
| $columnKey = lcfirst(str_replace('_', '', ucwords($column, '_'))); | ||
| $columnValue = lcfirst(str_replace(['.', '_'], '', ucwords($column, '._'))); |
There was a problem hiding this comment.
musíme nahradit customer.time_zone za customerTimeZone
michaljurecko
approved these changes
Apr 6, 2022
ondrajodas
force-pushed
the
ondra-change-getting-columns
branch
from
3964280
to
13c61b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://keboola.zendesk.com/agent/tickets/22081
https://keboola.zendesk.com/agent/tickets/21918