feat: Add support for tracing for http addon #1021
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
2 times, most recently
from
f945b23
to
1eb19da
Compare
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
from
f64c6dc
to
480050e
Compare
JorTurFer
reviewed
May 18, 2024
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
4 times, most recently
from
c95f18e
to
eb64c18
Compare
JorTurFer
reviewed
May 26, 2024
|
@bhussain91 any update on this please? |
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
from
eb64c18
to
b093281
Compare
@zroubalik I've refactored the code as per comments by @JorTurFer |
zroubalik
reviewed
Jun 6, 2024
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
2 times, most recently
from
8075523
to
91702b3
Compare
zroubalik
reviewed
Jun 7, 2024
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
from
91702b3
to
444c2b5
Compare
@zroubalik |
Signed-off-by: Bilal Hussain <bilal.hussain@10xbanking.com>
bhussain91
force-pushed
the
feature/keda-http-addon-tracing
branch
from
444c2b5
to
4d127f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bilal Hussain bilal.hussain@10xbanking.com
Provide a description of what has been changed
The change is to add tracing capability into the keda http addon using opentelemetry. The changes allows the add on to generate and export spans to console (development) or otel gRPC endpoint. Further information on how to configure tracing can be found in the docs
Checklist
README.mddocs/directoryFixes #